smtp: add --ehlo-domain/--helo-domain to set the client greeting name - #753
Merged
Conversation
The EHLO/HELO argument identifies the connecting client (RFC 5321 4.1.4), but the module sent the target's domain. Re-add flags to set it explicitly; when unset, behavior is unchanged (falls back to the target domain).
zakird
approved these changes
Aug 31, 2026
zakird
enabled auto-merge (squash)
August 31, 2026 03:46
zakird
disabled auto-merge
August 31, 2026 03:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EHLO/HELO argument identifies the connecting client (RFC 5321 4.1.4), but the module sent the target's domain. These flags were removed in 589d4e0. Re-add flags to set it explicitly; when unset, behavior is unchanged (falls back to the target domain).
How to Test
New flag
Regression (default behavior)